[5.2] SEF URLs: Check if SEF plugin is published#44283
Merged
pe7er merged 3 commits intojoomla:5.2-devfrom Nov 3, 2024
Merged
Conversation
Contributor
|
I am not up to date with 3rd party sef extensions but what if they require the core sef plugin to be disabled? |
Member
Author
|
That is the goal of this PR to allow this. |
ghost
mentioned this pull request
4 tasks
|
I have tested this item ✅ successfully on 1ac14e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 1ac14e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283. |
Contributor
|
Thanks @Hackwar ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44270.
Summary of Changes
The new changes for SEF URLs check the options in the SEF plugin. If the plugin is unpublished/disabled, the plugin data is not loaded and results in notices in the output if error reporting is turned up high enough.
Testing Instructions
Install 5.2 and set error reporting to maximum, as well as debugging to on. Unpublish the SEF system plugin.
Actual result BEFORE applying this Pull Request
Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php
Expected result AFTER applying this Pull Request
Nothing.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed